819895 - Different favicon for added search engine in urlbar/awesome bar search and about:addons (add-ons manager)

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Favicon Handling, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot url bar

Firefox for Android trunk 20121209, Android 4.1.2 (stock), Google Nexus S

The favicon for the search engine "Wikipedia SSL DE" I added to Firefox Mobile is different in the add-ons manager from the one shown in the urlbar. See attached screenshots.

Steps to reproduce:
1. Go to https://addons.mozilla.org/android/
2. Search for: Wikipedia SSL
3. Look for Wikipedia SSL (DE) and install it.
4. Type ggggg or something like this that won't be found in your history, notice the pixel garbage icon.
5. Open the add-ons manager from the Tools menu. Here you get what you expect.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot add-ons manager

Comment 2

[Aaron Train [:aaronmt]]

Does a build prior to the patch landing in bug 808663 (Nov 15th) make any difference?

Comment 3

[Wesley Johnston (:wesj)]

The addon provides a link to a 404 page for the icon:

https://secure.wikimedia.org/favicon.ico

Desktop shows the "Addon Manager" icon in this case. We could too.

Comment 4

[Wesley Johnston (:wesj)]

I'm not sure how we're getting something "right" in the addons manager....

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

have you looked at the correct search engine? It's https://addons.mozilla.org/android/addon/wikipedia-ssl-de/?src=ss and the source looks like this:

<?xml version="1.0" encoding="UTF-8"?> 
<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/" xmlns:moz="http://www.mozilla.org/2006/browser/search/"> 
  <ShortName>Wikipedia SSL DE</ShortName> 
  <Description>verschlüsselte Suche mit Wikipedia</Description> 
  <InputEncoding>UTF-8</InputEncoding> 
  <Image width="16" height="16" type="image/x-icon">data:image/x-icon;base64,AAABAAEAEBAQAAEABAAoAQAAFgAAACgAAAAQAAAAIAAAAAEABAAAAAAAAAAAAAAAAAAAAAAAEAAAAAAAAAAEAgQAhIOEAMjHyABIR0gA6ejpAGlqaQCpqKkAKCgoAPz9%2FAAZGBkAmJiYANjZ2ABXWFcAent6ALm6uQA8OjwAiIiIiIiIiIiIiI4oiL6IiIiIgzuIV4iIiIhndo53KIiIiB%2FWvXoYiIiIfEZfWBSIiIEGi%2FfoqoiIgzuL84i9iIjpGIoMiEHoiMkos3FojmiLlUipYliEWIF%2BiDe0GoRa7D6GPbjcu1yIiIiIiIiIiIiIiIiIiIiIiIiIiIiIiIgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA</Image> 
  <Url type="text/html" method="GET" template="https://de.wikipedia.org/wiki/Spezial:Suche">
    <Param name="search" value="{searchTerms}"/>
    <Param name="sourceid" value="Mozilla-search"/>
  </Url> 
  <Url type="application/x-suggestions+json" template="https://de.wikipedia.org/w/api.php">
    <Param name="action" value="opensearch"/>
    <Param name="search" value="{searchTerms}"/>
  </Url> 
  <moz:SearchForm>https://de.wikipedia.org/wiki/Spezial:Suche</moz:SearchForm> 
</OpenSearchDescription>

As you can see the image is embedded into the xml.

Comment 6

[Wesley Johnston (:wesj)]

Ahh. No I was looking at the US version:

https://addons.mozilla.org/en-US/android/addon/wikipedia-ssl-243981/?src=ss

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Archaeopteryx [:aryx] from comment #5)
> have you looked at the correct search engine? It's

>   <Image width="16" height="16"
> type="image/x-icon">data:image/x-icon;base64,

> As you can see the image is embedded into the xml.

And it's 16px so we stretch it

Comment 8

[Chris Kitching [:ckitching]]

The Favicon revamp of bug 888326 fixes this problem.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 12

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.